-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix broken --sheet-name
argument
#6401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BTerminal into feature/remove-hold
…e sheet_name issue when writing to excel
…BTerminal into feature/remove-hold
When I don't specify
|
IgorWounds
approved these changes
May 13, 2024
I believe this fixes: 45bfac2 Thank you @deeleeramone If it still fails somehow, please share the exact command! |
deeleeramone
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--sheet-name
works, on to the next!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? (1-3 sentences or a bullet point list):
--sheet-name
argumentWhat? (1-3 sentences or a bullet point list):
OBBjects
)sheet-name
needed to be converted from a list to a string.Impact (1-2 sentences or a bullet point list):
Testing Done:
/equity/fundamental/ $ balance --symbol MSFT --period quarter --export msft_financials.x lsx --sheet-name balance
/equity/fundamental/ $ cash --symbol MSFT --period quarter --export msft_financials.xlsx --sheet-name cash
Reviewer Notes (optional):