Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] - Replace python-jose by PyJWT #6407

Merged
merged 7 commits into from
May 14, 2024
Merged

[BugFix] - Replace python-jose by PyJWT #6407

merged 7 commits into from
May 14, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented May 13, 2024 •
edited
Loading

  1. Why?

    • python-jose contains security vulnerabilities and is not maintained

  2. What?:

    • Replace it by PyJWT

  3. Impact:

    • NA

  4. Testing Done:

    • Adds unit test for valid, expired and invalid token

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 13, 2024
@montezdesousa montezdesousa marked this pull request as ready for review May 13, 2024 19:18
@montezdesousa montezdesousa requested review from piiq and hjoaquim May 13, 2024 19:18
@piiq piiq added this pull request to the merge queue May 14, 2024
Merged via the queue into develop with commit 0769378 May 14, 2024
10 checks passed
@montezdesousa montezdesousa deleted the bugfix/bye-jose branch May 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq piiq approved these changes

@hjoaquim hjoaquim Awaiting requested review from hjoaquim

Assignees

@montezdesousa montezdesousa

Labels
bug Fix bug P1 platform OpenBB Platform security v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montezdesousa @piiq