Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Forward EBITDA #6433

Merged
merged 9 commits into from
May 20, 2024
Merged

[Feature] Forward EBITDA #6433

merged 9 commits into from
May 20, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented May 18, 2024 •
edited
Loading

  1. Why?:

    • Adding to the equity.estimates route.

  2. What? (1-3 sentences or a bullet point list):

    • New route: obb.equity.estimates.forward_ebitda
    • Support for FMP and Intrinio

  3. Impact:

    • Additional maintenance for new route and models.

  4. Testing Done:

    • With/without symbol(s).
    • Unit & integration tests.

Screenshot 2024-05-18 at 11 21 29 AM

  1. Reviewer Notes (optional):

    • Lookup by symbol does not work for all symbols from Intrinio, this is an issue on their side.

@deeleeramone deeleeramone added enhancement Enhancement do not merge Label to prevent pull request merge platform OpenBB Platform labels May 18, 2024
@deeleeramone deeleeramone removed the do not merge Label to prevent pull request merge label May 18, 2024
@deeleeramone deeleeramone marked this pull request as ready for review May 18, 2024 18:22
@deeleeramone deeleeramone requested a review from IgorWounds May 20, 2024 16:56
@IgorWounds IgorWounds enabled auto-merge May 20, 2024 19:02
@IgorWounds IgorWounds added this pull request to the merge queue May 20, 2024
Merged via the queue into develop with commit bffd88f May 20, 2024
9 checks passed
@IgorWounds IgorWounds deleted the feature/forward-ebitda branch May 21, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds