Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Handle space separated arguments #6436

Merged
merged 2 commits into from
May 20, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • CLI was not capable of proper handling of space separated arguments, even when using quotes or escape characters.
  2. What? (1-3 sentences or a bullet point list):

    • Use shlex to handle the user's input.
  3. Impact (1-2 sentences or a bullet point list):

    • Significant UX improvement, allowing users to use space separated arguments where applicable
  4. Testing Done:

    • Use space separated options:
      • filings --symbol aapl --form_type "NT N-MFP" --provider fmp
      • filings --symbol aapl --form_type NT\ N-MFP --provider fmp

Before those would result in an choices error: "Choose from..."

  1. Reviewer Notes (optional):

    • The examples above are illustrative and will most likely result in empty data error.

@hjoaquim hjoaquim requested a review from IgorWounds May 20, 2024 09:22
@github-actions github-actions bot added the bug Fix bug label May 20, 2024
@montezdesousa montezdesousa added this pull request to the merge queue May 20, 2024
Merged via the queue into develop with commit c65c4ad May 20, 2024
9 checks passed
@hjoaquim hjoaquim deleted the bugfix/handle-space-separated-args branch May 20, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants