Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Deprecate etf.holdings_performance endpoint #6441

Merged
merged 7 commits into from
May 20, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Remove deprecated endpoint.
  2. What? (1-3 sentences or a bullet point list):

    • Remove code and tests refering to such endpoint.
  3. Impact (1-2 sentences or a bullet point list):

    • Minimal
Impact analysis
  User Experience (UX) Impact:
    3: Noticeable UI/UX changes, some user guidance needed
    
> Endpoint is gone.

Performance Impact:
    0: Neutral

Compatibility Impact:
    3: Moderate adaptation for compatibility
    
    > Endpoint not supported in future versions.

Security Impact:
    0: Neutral

Scalability Impact:
    0: Neutral

Maintenance Impact:
    0: Reduces maintenance

Compliance Impact:
    0: Fully compliant, no changes

Dependency Impact:
    0: No change

Scoring:
Total Score: 6 / 40

  1. Testing Done:

    • Run unit and integration tests (etf only).

@github-actions github-actions bot added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 breaking_change labels May 20, 2024
@hjoaquim hjoaquim changed the title [Feature] Deprecate etf.holding_performance endpoint [Feature] Deprecate etf.holdings_performance endpoint May 20, 2024
@IgorWounds IgorWounds added this pull request to the merge queue May 20, 2024
Merged via the queue into develop with commit e292237 May 20, 2024
12 checks passed
@IgorWounds IgorWounds deleted the feature/deprecate-etf-holding-performance branch May 21, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants