-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows #6443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezdesousa
changed the title
Bugfix/update anyio ruff
[Bugfix] Update anyio & sync pre-commit, openbb-devtools and GitHub workflows
May 20, 2024
piiq
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump black to latest
montezdesousa
changed the title
[Bugfix] Update anyio & sync pre-commit, openbb-devtools and GitHub workflows
[Bugfix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows
May 21, 2024
montezdesousa
changed the title
[Bugfix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows
[BugFix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows
May 21, 2024
piiq
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try. I would also remove the devtools section from cli, but that's for a different PR
IgorWounds
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
anyio
version had to be pinned to v3->v4 to avoid import errorpre-commit
hooks were out of sync vsopenbb-devtools
which defines GitHub workflow dependency versionsruff
version use inopenbb-core
was too restrictive and outdatedmypy
errors were different in GitHub workflow and locallyWhat?
anyio
^3.7.0 -> ^4.3.0ruff
^0.1.6 -> >=0.1.6,<=0.4.4 (devtools uses ^0.4.4)black
24.1.0 -> 24.4.2 (devtools)pre-commit
hooks withopenbb-devtools
ruff
,mypy
,pydocstyle
fixespyptoject.toml
Impact:
Testing Done: