Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Revamp the usage of list syntax on routines #6450

Merged
merged 6 commits into from
May 22, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Recover the usage of list syntax inside routines.
  2. What? (1-3 sentences or a bullet point list):

    • Treat the argument -i/--input as a string initially and skip those on split comma separated arguments.
    • Use a regular expression to handle list-like syntax before parsing the openbb script.
  3. Impact (1-2 sentences or a bullet point list):

    • Minimal 3/40
Impact Analysis
User Experience (UX) Impact:
    0: No change to UX

Performance Impact:
    0: Neutral

Compatibility Impact:
    2: Minor compatibility issues

    > older versions wont have this upgrade.


Security Impact:
    0: Neutral

Scalability Impact:
    1: Minor scalability improvements/challenges

    > we might have challenges if other syntaxes are introduced

Maintenance Impact:
    1-2: Minor maintenance impact

    > we might have challenges if other syntaxes are introduced

Compliance Impact:
    0: Fully compliant, no changes

Dependency Impact:
    0: No change

Scoring:

Total Score: 3 / 40
  1. Testing Done:

    • Create a routine with the following content: /equity/price/historical --symbol $ARGV[0] --start_date $ARGV[1] --provider yfinance --chart
    • Run it with multiple symbols: exe --file xpto.openbb --input [AAPL,MSFT],2024-01-01

@hjoaquim hjoaquim added the cli OpenBB Platform CLI label May 21, 2024
@github-actions github-actions bot added the bug Fix bug label May 21, 2024
Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this also takes care of FOREACH loops.

@hjoaquim hjoaquim added this pull request to the merge queue May 22, 2024
Merged via the queue into develop with commit f91791d May 22, 2024
9 checks passed
@IgorWounds IgorWounds deleted the bugfix/routines-w-lists branch May 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug cli OpenBB Platform CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants