Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linters on changed files only #6458

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented May 23, 2024

  • general-linting.yaml workflow might fail in unchanged files when linters have new versions (allowed by openbb-devtools). Just happened with ruff v0.4.5, where a file I didn't touch breaks new ruff version

file: openbb_platform/obbject_extensions/charting/openbb_charting/core/openbb_figure.py
action: https://github.com/OpenBB-finance/OpenBBTerminal/actions/runs/9206586424/job/25324754940

  • Use more permissive version of ruff in openbb-core to avoid conflicts with openbb-devtools
  • Update ruff in pre-commit hooks. v0.4.5 was released and openbb-devtools allows it
  • mypy was deleted from workflow checks in the release, it's added here
  • linters were not running for cli/

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 23, 2024
@montezdesousa montezdesousa added this pull request to the merge queue May 23, 2024
Merged via the queue into develop with commit 1e46549 May 23, 2024
16 of 17 checks passed
@IgorWounds IgorWounds deleted the bugfix/linters-worflow branch May 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants