Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Convert Params Models To Dictionary Before Assigning As Private Attribute In OBBject. #6492

Merged
merged 11 commits into from
Jun 13, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • ^^

    • Every process downstream accessing this private attribute converts to a dictionary immediately, so this does the job once instead of repeating in multiple places.

  2. What?:

    • obbject._standard_params is now a dictionary.
    • Updated the registry in CLI to reflect the change.
    • Updated openbb-charting init to reflect the change.
  3. Impact:

    • This only impacts the charting extension and CLI, however there is no operational change beyond the type conversion.
  4. Testing Done:

    • Ran the integration tests.

@github-actions github-actions bot added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Jun 7, 2024
@deeleeramone deeleeramone requested a review from hjoaquim June 12, 2024 19:28
@hjoaquim hjoaquim added this pull request to the merge queue Jun 13, 2024
Merged via the queue into develop with commit 8b9f461 Jun 13, 2024
12 checks passed
@IgorWounds IgorWounds deleted the feature/params-model-to-dict branch June 16, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants