Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix OECD Unemployment Age Brackets & Fix No module named 'pkg_resources' #6563

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Jul 3, 2024

  1. Why?:

    • The age brackets have changed on OECD Data Explorer and there are only 3 valid brackets.
    • pkg_resources is deprecated, and version needed to be updated to use importlib.metadata.
      • This caused an ImportError and the Platform failed to initialize when 3.9 was used.

In other versions I receive a warning:

DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
  1. What?:

    • Update the choices for Age in economy.unemployment
    • Refactor version.py to use importlib.metadata
    • Update static assets.
  2. Impact:

    • Age brackets working as expected.
    • Python 3.9 will now import the Platform.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jul 3, 2024
@deeleeramone deeleeramone requested a review from IgorWounds July 3, 2024 18:52
@deeleeramone deeleeramone changed the title [BugFix] Fix OECD Unemployment Age Brackets & Fix pkg_resources Not In Python 3.9 [BugFix] Fix OECD Unemployment Age Brackets & Fix No module named 'pkg_resources' Jul 3, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Jul 4, 2024
Merged via the queue into develop with commit 8877f61 Jul 4, 2024
21 of 22 checks passed
@IgorWounds IgorWounds deleted the bugfix/oecd-unemployment-ages branch July 4, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants