Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Charting Integration Tests #6569

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Jul 9, 2024

  1. Why? (1-3 sentences or a bullet point list):

    • Charting integration tests breaking.
  2. What? (1-3 sentences or a bullet point list):

    • Remotes the default value for the Chart.format and outsource that responsibility for the extension.
    • The extension explicitly says what's the format during chart creating (obbject.chart = Chart(...))
  3. Impact (1-2 sentences or a bullet point list):

    • NA
  4. Testing Done:

    • Running integration tests.
    • Running endpoints with and without charting implementation (python + api)

@hjoaquim hjoaquim requested a review from montezdesousa July 9, 2024 10:39
@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jul 9, 2024
@hjoaquim hjoaquim changed the title [BugFix] [BugFix] Charting Integration Tests Jul 9, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Jul 9, 2024
Merged via the queue into develop with commit 8ac72c6 Jul 9, 2024
13 of 14 checks passed
@IgorWounds IgorWounds deleted the bugfix/charting-tests branch July 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants