Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix gdp.forecast #6585

Merged
merged 3 commits into from
Jul 16, 2024
Merged

[BugFix] Fix gdp.forecast #6585

merged 3 commits into from
Jul 16, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Jul 13, 2024

  1. Why?:

    • Running this command downloads a 173MB file, every time.
  2. What?:

    • Fix the function to hit the endpoint with parameters and exclude non-data from the download.
    • Parameters:
      • country: multiple items allowed
      • frequency: ["annual", "quarter"]
      • units: ["current_prices", "volume", "capita", "growth", "deflator"]
  3. Impact:

    • File size can now be measured in KBs.
    • Improved response time.
    • New parameters.
  4. Testing Done:

    • Removed the skip in the unit tests.
    • Updated integration tests for parameters.

Screenshot 2024-07-13 at 12 20 35 PM

There is some data that doesn't make any sense, units='current_prices', and no amount of fudge-factor could justify these numbers. Inflation doesn't make Argentina's nominal GDP, expressed in USD, 2X the world's largest economy.

Screenshot 2024-07-13 at 12 33 46 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jul 13, 2024
@deeleeramone deeleeramone requested a review from IgorWounds July 13, 2024 19:22
@IgorWounds
Copy link
Contributor

@deeleeramone should we send in a warning with this data for users stating that some of it doesn't seem accurate?

@deeleeramone
Copy link
Contributor Author

@deeleeramone should we send in a warning with this data for users stating that some of it doesn't seem accurate?

Seems like a slippery slope to head down, but I did add a comment in the code highlighting the sus param. Ultimately, it's up to the user to determine the accuracy of the data, correct? I hid it by not returning that as the default.

@IgorWounds IgorWounds added this pull request to the merge queue Jul 16, 2024
Merged via the queue into develop with commit 869d917 Jul 16, 2024
14 checks passed
@IgorWounds IgorWounds deleted the bugfix/gdp-forecast branch July 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants