Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] PyWry Optional With Charting #6590

Merged
merged 12 commits into from
Jul 29, 2024
Merged

[Feature] PyWry Optional With Charting #6590

merged 12 commits into from
Jul 29, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • To make PyWry an optional library, and only a named dependency for openbb-cli

  2. What?:

    • Remove core settings/preferences that begin with "pywry"
    • Update lock/toml files.

  3. Impact:

    • Platform interactive tables will be temporarily unavailable until a replacement can be put in.
    • The charting service continues to work, unintended consequences will likely arise.
    • Improved ease-of-installation within Linux environments.
    • Smaller package footprint.

  4. Testing Done:

    • Stuff continues to work, nothing "breaks" unexpectedly.

    • More thorough testing is required.

@deeleeramone deeleeramone added enhancement Enhancement platform OpenBB Platform cli OpenBB Platform CLI labels Jul 17, 2024
@github-actions github-actions bot added the v4 PRs for v4 label Jul 17, 2024
@deeleeramone deeleeramone mentioned this pull request Jul 17, 2024
Merged
@deeleeramone deeleeramone marked this pull request as ready for review July 17, 2024 18:44
piiq
piiq reviewed Jul 27, 2024
View reviewed changes
openbb_platform/obbject_extensions/charting/openbb_charting/core/backend.py Outdated
if Env().DEBUG_MODE:
print(f"\033[91m{e}\033[0m") # noqa: T201
except ImportError:
# if Env().DEBUG_MODE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clean this up please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean, remove the commented lines? If so, done.

@IgorWounds IgorWounds added this pull request to the merge queue Jul 29, 2024
Merged via the queue into develop with commit 586df54 Jul 29, 2024
14 checks passed
@IgorWounds IgorWounds deleted the feature/pywry-optional branch July 29, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

@piiq piiq piiq approved these changes

@hjoaquim hjoaquim Awaiting requested review from hjoaquim

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

Assignees
No one assigned
Labels
cli OpenBB Platform CLI enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deeleeramone @piiq @IgorWounds