Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Consolidate OECD Interest Rate Endpoints as a Single Function #6602

Merged
merged 11 commits into from
Aug 2, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Unnecessary endpoints existing where the only difference is one parameter.
  2. What?:

    • Deprecates:
      • obb.economy.immediate_interest_rate
      • obb.economy.long_term_interest_rate
      • obb.economy.short_term_interest_rate
    • Adds:
      • obb.economy.country_interest_rates
  3. Impact:

    • Removes redundant code and improves organization of endpoints.
  4. Testing Done:

    • Integration/Unit
    • CLI

Screenshot 2024-07-31 at 4 02 34 PM
Screenshot 2024-07-31 at 4 09 37 PM

@deeleeramone deeleeramone added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Jul 31, 2024
@deeleeramone deeleeramone requested a review from IgorWounds July 31, 2024 23:17
@jmaslek
Copy link
Collaborator

jmaslek commented Aug 1, 2024

thoughts on just calling it interest_rates instead of country_interest_rates

@deeleeramone
Copy link
Contributor Author

thoughts on just calling it interest_rates instead of country_interest_rates

not opposed.

@IgorWounds
Copy link
Contributor

LGTM! I'd add the change @jmaslek proposed @deeleeramone.

@deeleeramone
Copy link
Contributor Author

LGTM! I'd add the change @jmaslek proposed @deeleeramone.

If no objections, I'll keep the model name as 'CountryInterestRates' so not to create confusion with something that may belong with Fixed Income.

@IgorWounds IgorWounds added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 804a67f Aug 2, 2024
10 checks passed
@IgorWounds IgorWounds deleted the feature/oecd-cleanup branch August 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants