Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix Rogue Percent Value In FMP ETF Info #6607

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[BugFix] Fix Rogue Percent Value In FMP ETF Info #6607

merged 1 commit into from
Aug 2, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Percentage value not correctly reflected in expense_ratio field.

  2. What?:

    • Apply field_validator.

  3. Impact:

    • Value is stored as-expected now.

  4. Testing Done:

    • obb.etf.info("VOO", provider="fmp")

Screenshot 2024-08-01 at 5 09 07 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Aug 2, 2024
@deeleeramone deeleeramone requested a review from IgorWounds August 2, 2024 00:10
@IgorWounds IgorWounds added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 802d7fb Aug 2, 2024
13 checks passed
@IgorWounds IgorWounds deleted the bugfix/fmp-etf-expense-ratio branch August 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds