Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - LoggingService changing default logging configuration #6681

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Sep 20, 2024

Description

  • Fixes [Bug] OpenBB Platform hijacks default logger #6680
  • The LoggingService and HandlersManager classes were changing the default logger configurations. Now a custom logger is created and used for this purpose, without changing the default configuration.

How has this been tested?

  • Checked logs are correct in the logs folder
  • Checked stdout logs are correct
import logging
logging.basicConfig(level=logging.INFO)
logging.info("This message is shown")
import openbb
logging.info("This message is hidden") # This message should NOT be hidden anymore

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Sep 20, 2024
@montezdesousa montezdesousa changed the title Fix logging service changing global logging config [BugFix] - Logging service changing default logging configuration Sep 20, 2024
@montezdesousa montezdesousa changed the title [BugFix] - Logging service changing default logging configuration [BugFix] - LoggingService changing default logging configuration Sep 20, 2024
Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised.

Screenshot 2024-09-20 at 8 20 19 AM

@montezdesousa montezdesousa added this pull request to the merge queue Sep 20, 2024
@montezdesousa montezdesousa removed this pull request from the merge queue due to a manual request Sep 20, 2024
@montezdesousa montezdesousa added the do not merge Label to prevent pull request merge label Sep 20, 2024
@piiq piiq removed the do not merge Label to prevent pull request merge label Sep 23, 2024
@montezdesousa montezdesousa added this pull request to the merge queue Sep 23, 2024
Merged via the queue into develop with commit 24bc340 Sep 23, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/logging-service-fix branch September 26, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] OpenBB Platform hijacks default logger
5 participants