Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] API: Handle EmptyDataError As Status Code 204 #6682

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[BugFix] API: Handle EmptyDataError As Status Code 204 #6682

wants to merge 3 commits into from

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • EmptyDataError was triggering a 500 error and is not being handled.

  2. What?:

    • Adds an exception handler to the API for EmptyDataError and return a Response object instead of JSONResponse.

  3. Impact:

    • EmptyDataError is now handled properly in the API.

  4. Testing Done:

After:
Screenshot 2024-09-20 at 9 38 01 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq Awaiting requested review from piiq

@IgorWounds IgorWounds Awaiting requested review from IgorWounds

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deeleeramone