Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] API: Handle EmptyDataError As Status Code 204 #6682

Merged
merged 11 commits into from
Oct 3, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • EmptyDataError was triggering a 500 error and is not being handled.
  2. What?:

    • Adds an exception handler to the API for EmptyDataError and return a Response object instead of JSONResponse.
  3. Impact:

    • EmptyDataError is now handled properly in the API.
  4. Testing Done:

After:
Screenshot 2024-09-20 at 9 38 01 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Sep 20, 2024
@IgorWounds
Copy link
Contributor

Tagging @andrewkenreich here too.

@piiq
Copy link
Contributor

piiq commented Sep 23, 2024

@andrewkenreich feel free to merge this one once you digest the changes

@deeleeramone deeleeramone added this pull request to the merge queue Oct 3, 2024
Merged via the queue into develop with commit c786852 Oct 3, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/handle-api-empty-response branch October 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants