Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🕹️]Added the notebook for Backtesting Momentum Strategies #6759

Merged

Conversation

SanchitMahajan236
Copy link
Contributor

@SanchitMahajan236 SanchitMahajan236 commented Oct 10, 2024

  1. Why? (1-3 sentences or a bullet point list):
  • To provide users with the ability to backtest momentum-based trading strategies within the OpenBB framework.
  • This enhancement allows for historical performance evaluation, helping traders identify profitable patterns.
  • Addresses user requests for more sophisticated strategy testing tools.
  1. What? (1-3 sentences or a bullet point list):
  • Added functionality to backtest momentum trading strategies using historical price data.
  • Implemented momentum indicators such as RSI and Moving Averages to simulate trades based on defined strategy rules.
  • Integrated results visualization for clear performance insights.
  1. Impact (1-2 sentences or a bullet point list):
  • Expected to enhance user capability to test and refine momentum strategies, leading to more informed trading decisions.

  • Minimal impact on system performance, with backtesting execution time expected to increase by ~5%.

  • Impact score: 8

    [!TIP]
    Refer to the Impact Analysis confluence (internal) document for more information.

  1. Testing Done:
  • Validated using historical stock price data across various market conditions.
  • Simulated multiple momentum-based strategies to ensure accuracy and reliability of results.

Closes #6712

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

@SanchitMahajan236
Copy link
Contributor Author

Hi @jmaslek, please review my PR.

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 16, 2024

Can you supress the pandas warnings then I will approve and merge and award

@SanchitMahajan236
Copy link
Contributor Author

Hey @jmaslek, I have addressed the pandas warning. You can review the PR.

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 17, 2024

/award 300

Copy link

oss-gg bot commented Oct 17, 2024

Awarding SanchitMahajan236: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/SanchitMahajan236

@piiq piiq added this pull request to the merge queue Oct 18, 2024
Merged via the queue into OpenBB-finance:develop with commit 4a448de Oct 18, 2024
6 checks passed
Copy link

oss-gg bot commented Oct 18, 2024

Awarding SanchitMahajan236: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/SanchitMahajan236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Create a Notebook for Backtesting Momentum Strategies
4 participants