Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/senate trading rss #6832

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mmistroni
Copy link
Contributor

Pull Request Template for OpenBB Developers

  1. Title:

    • [Improvement] - Exposing FMP Senate Trading endpoint.
  2. Why? (1-3 sentences or a bullet point list):

    • Useful to have for equity discovery investigation, alongside Edgar Filings
  3. What? (1-3 sentences or a bullet point list):

    • A new Fetcher has been created to expose FMP Senate Trading RSS endpoint, which shows the last 100 days worth of trades from member of US Senate
  4. Impact (1-2 sentences or a bullet point list):

    • Low: this is a brand new endpoint which is exposed via Equity Discover
  5. Testing Done:

    • Unit tests as well as api call, see below

    obb.equity.discovery.senate_trading()
    firstName lastName office link dateRecieved ... assetType type amount comment symbol
    0 John Boozman John Boozman https://efdsearch.senate.gov/search/view/ptr/e... 2024-10-17 ... Stock Sale (Partial) $1,001 - $15,000 -- IWM
    1 John Boozman John Boozman https://efdsearch.senate.gov/search/view/ptr/e... 2024-10-17 ... Stock Sale (Partial) $1,001 - $15,000 -- IVV
    2 John Boozman John Boozman https://efdsearch.senate.gov/search/view/ptr/e... 2024-10-17 ... Stock Sale (Partial) $1,001

  6. Reviewer Notes (optional):

    • Please check algorithm compatibility with existing data models.
  7. Any other information (optional)
    N.A

@deeleeramone
Copy link
Contributor

Hi, @mmistroni, and thanks for the PR.

There's another PR open for the same provider and endpoint, #6761, perhaps y'all could team up to divide-and-conquer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants