Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Make "logging_suppress" in SystemSettings Mutable and Then Actually Suppress Logging Service #6933

Merged
merged 8 commits into from
Nov 11, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Nov 5, 2024

  1. Why?:

  2. What? :

    • Allows logging_suppress to be defined in system_settings.json.
    • When true, the file and PostHog handlers are not added, nothing gets recorded to the ~/OpenBBUserData/logs folder.
  3. Impact:

    • Improves compatibility over VPN and blocking network infrastructure.
    • Improves user privacy by offering a complete offramp to the logging service.
  4. Testing Done:

    • Add tosystem_settings.json and observe that no startup log file is created.:
{
    "logging_suppress": true
}

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Nov 5, 2024
@piiq piiq added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 804534e Nov 11, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-logging-suppress branch December 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Getting a HTTPS error pointing to us.i.posthog.com when running the basic getting started code
4 participants