Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Parsing Error In SEC Form13F #6961

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[BugFix] Fix Parsing Error In SEC Form13F #6961

merged 3 commits into from
Nov 25, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • This fixes an issue in, obb.equity.ownership.form_13f, where aggregation silently failed because of unfilled NaN values in a string field.
    • Observable in when the 'asset_class' contained both options and share classes. Results would only aggregate the options positions.
  2. What?:

    • Fills the NaN with a string value to allow the group aggregation, then replaces on output.
    • Renames a misnamed optional field to align with the definition, "voting_authority_other" -> "voting_authority_none"
    • General maintenance with some code cleanup.
  3. Impact:

    • Fixes missing output
    • Slightly better performance
  4. Testing Done:

    • This was generally focused around a very large file (25MB text) that takes a long time to process.
      • obb.equity.ownership.form_13f(symbol="0002012383", provider="sec")
Screenshot 2024-11-23 at 12 33 43 AM Screenshot 2024-11-23 at 12 31 47 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Nov 23, 2024
@piiq piiq enabled auto-merge November 25, 2024 17:00
@piiq piiq added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 99b7614 Nov 25, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/sec-13f-agg branch December 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants