Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] equity.peers: Handle Empty Values Within FMP Response #6963

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[BugFix] equity.peers: Handle Empty Values Within FMP Response #6963

merged 2 commits into from
Nov 25, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • FMP will return empty items within the response, for some unknown reason.

  2. What?:

    • Check the response for empty items and remove them.

  3. Impact:

    • Better quality results without a weird empty symbol.

  4. Testing Done:

obb.equity.compare.peers("BUDZ")

Response before:

image

Response after:

Screenshot 2024-11-25 at 8 36 42 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Nov 25, 2024
@piiq piiq added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 23c8780 Nov 25, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-empty-equity-peers branch December 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkenreich andrewkenreich andrewkenreich approved these changes

@piiq piiq piiq approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deeleeramone @piiq @andrewkenreich