Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocab parallel Embedding impl and make example work when tp_size > 1 #186

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

MayDomine
Copy link
Collaborator

Vocab Parallel Embedding implementation

Description

Provide Vocab Parallel Embedding for TP-Parallel in bmt.nn.parallel_embedding.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MayDomine MayDomine merged commit 5713d76 into dev Feb 26, 2024
6 checks passed
@MayDomine MayDomine deleted the vpe branch February 26, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant