-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate comments in Chinese to English for broader users #123
Conversation
Changed most chinese comments to english. But also changed the code format of some files as side effect. It seems there is no code convention for this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to accomplish two things: first, it uses an IDE or code optimization tool to improve the code style, and second, it translates the comments from Chinese to English.
But I think these two changes should be split into two separate PRs to maintain atomicity because in my opinion, changing the code style is considered a breaking change.
I'm just curious how a complete translation is achieved. Do you have any tools to accomplish it quickly?
I agree. This code formatting is a side effect. I can disable and try again.
You can do a search with regular expression in visual studio code. |
revert format change caused by IDE to make review easier.
Changed most Chinese comments to English. But also changed the code format of some files as side effect. It seems there is no code convention for this project.
🤔 What is the nature of this change? / 这个变动的性质是?
📝 Changelog / 更新日志
No changes for the user side.