Tor #560

rmisio · 2017-07-11T20:10:44Z

This change-set wires in Tor controls to the client.

closes #315

To test:

Ensure Tor will run on your machine without authentication
a. Download the Tor browser.
b. Start up the Tor browser.
c. Attempt to start your server with the --tor flag. If it works, you'll see this in the terminal ([Execute] [NOTICE] Using Tor exclusively) and you're free to proceed to step 2. If it doesn't work, you'll likely see some type of auth error in the terminal. In that case, please ping @rmisio for further debugging.

The following steps will allow your client to masquerade as the bundled app and test Tor scenarios specific to the bundled (installer) version of the app.

Ensure no OB servers are running.
Start-up the client and run localStorage.clear() in the console.
Shut-down the client.
Download the latest Server release for your OS. Rename it to openbazaard on Linux or Mac, openbazaard.exe on Windows. Ensure the file is exectuable (chmod +x on Mac and Linux)
Edit main.js with the path to the executable in the previous step. Find the first line, comment it out and add the second line.

// const serverPath = `${__dirname}${path.sep}..${path.sep}openbazaar-go${path.sep}`;
const serverPath = '/path/to/executable/'; // do not include filename, do include trailing `/`

Start up the client. It will create a server configuration and attempt to connect to the built-in server that you downloaded.

If you are able to set-up a remote server, it would be a really good test to toggle your connection between a remote server and the built-in server and ensure that the connection is properly in Tor mode when you configure it (check 'use Tor') to be.

…rn data

…n external link

…nnect module

…et properly

cpacia · 2017-07-12T17:47:59Z

Not seeing the tor icon in the url bar

rmisio · 2017-07-12T17:58:23Z

@cpacia The tor indicator will show up when the following conditions are met:

1.) Your are connected to a server that was started in tor mode and that server is returning tor: true via the ob/config api.
2.) In the client, the server configuration for that connection is configured to use Tor:

Are both those conditions met for you?

cpacia · 2017-07-12T18:10:48Z

Oh duh that's right I have to set it in the config

cpacia · 2017-07-12T18:12:56Z

Ok this is what I wanted to show... the icon is a bit choppy on my system.

rmisio · 2017-07-12T18:18:46Z

I think I'll leave choppy icons to @morebrownies . The client is sizing the icon down to 13px to try and match the design. Do you want to play around with maybe bumping it up or down a pixel or two and seeing if that helps?

Maybe at 14px it looks better?

(It may just be an overly detailed icon that's not designed to be shown that small, at least on non-retina displays)

morebrownies · 2017-07-12T19:00:14Z

Ok, I'll try to get around to testing this later today.

morebrownies · 2017-07-13T19:46:56Z

@rmisio @cpacia I'm attempting to run my server with Tor and I'm running into this issue:

| => go run openbazaard.go start -t --tor
OpenBazaar Server v0.6.4 starting...
12:43:40.067 [Execute] [ERROR] Authentication failed: invalid (empty) COOKIEFILE
Authentication failed: invalid (empty) COOKIEFILE
exit status 1

Any idea what is going on with my 🍪 file?

rmisio · 2017-07-13T20:00:55Z

@morebrownies Yeah, it's the same thing Josh is going through. You're basically confirming that the Tor Browser needs specific configuration before being able to work with OB. @jjeffryes is working through putting together an instruction doc for it as I type (for Win and Mac). You may want to wait until he's done and work off that.

Basically, you need to configure your Tor Browser to use a password and give that password to the OB config.

If you want the cliff's notes version (for Mac):

in terminal navigate to /Applications/TorBrowser.app/Contents/MacOS/Tor
execute ./tor.real --hash-password mypassword. This will output a hashed version of the password.
cd ~/Library/Application\ Support/TorBrowser-Data/Tor and edit torrc by adding this line:
HashedControlPassword 16:0E016FA8F074C73460B7B55C1258A01CE5EA152282A20B8F7840948C3A
(use the hashed password from the previous step in place of the hash in the line above)
also add in this line CookieAuthentication 0. If there already was a line for CookieAuthentication, then replace it so it is set to 0.
now edit your ob config, but give it the plain text password:

  "Tor-config": {
    "Password": "mypassword",
    "TorControl": ""
  },

now you should be able to start the OB server in Tor mode. You'll need to bounce the Tor browser.

morebrownies · 2017-07-13T20:20:05Z

Ok great thank you @rmisio I'll give this a shot

morebrownies · 2017-07-13T20:57:51Z

I didn't get very far on this one @rmisio

| => cd /Applications/TorBrowser.app/Contents/Resources/TorBrowser/Tor
total 5576
drwxr-xr-x@ 3 Wolf admin 102B Jul 2 10:28 PluggableTransports/
-rw-r--r--@ 1 Wolf admin 3.5M Jul 1 07:53 geoip
-rw-r--r--@ 1 Wolf admin 2.0M Jul 1 07:53 geoip6
-rwxr-xr-x@ 1 Wolf admin 735B Jul 1 07:53 tor
-rw-r--r--@ 1 Wolf admin 798B Jul 1 07:53 torrc-defaults

| /Applications/TorBrowser.app/Contents/Resources/TorBrowser/Tor @ Mikes-MacBook-Pro (Wolf)
| => ./tor.real --hash-password mypassword
-bash: ./tor.real: No such file or directory

rmisio · 2017-07-13T21:05:01Z

Eternal damnation! I gave you the wrong path!

Sorry @morebrownies, it's /Applications/TorBrowser.app/Contents/MacOS/Tor

jjeffryes

Looks good. I found one spot that looks like it has the wrong variable, and had a question. Very minor.

jjeffryes · 2017-07-14T16:30:10Z

js/models/ServerConfig.js

+        if (split.length !== 2) {
+          valid = false;
+        } else {
+          if (!is.ip(valid[0])) {


Shouldn't this be split[0], since valid is a boolean, and split has the ip address?

jjeffryes · 2017-07-14T18:07:13Z

js/views/modals/connectionManagement/Configurations.js

+        // open, we won't auto send them to the config form, since it may interrupt something else
+        // they may be doing.
+        this.trigger('editConfig', {
+          model: this.collection.defaultConfig,


Can this also happen if you're using a configuration that isn't default, but is using Tor?

No, we would only get a 'tor-not-available' error on the default (i.e. built-in) server, because that's the only one that we control and can start-up via the status command to determine if Tor is available. For stand-alon servers, it is the responsibility of the user to start the server in Tor mode. If they forget to start the Tor browser and they start the server with --tor, then it will fail to start.

And... if they forget to start their server in Tor mode and connect via the client (even with Use Tor checked on the client), they have leaked their IP. They will not see the Tor indicator, but it's already too late.

Users managing their own server will have a big responsibility on them.

rmisio · 2017-07-17T17:25:04Z

@jjeffryes this should be ready to code with code review updates. Also added in a 'Tor active' tooltip at @morebrownies request.

rmisio added 23 commits June 30, 2017 16:20

fixed issue on the connected peers page when the endpoint doesnt retu…

c4aeb7e

…rn data

WIP - handling the tor needs configuration connection state

f7af997

fixed bug in check to ensure only one default config can be saved

68e759d

WIP - managing tor in the server connect module connect function

bc99273

more work on the configuration form configure tor state

d6a3a3e

finished up the configuration form configure-tor state

6f4989e

fixing lint errors

acfc322

added in the UI to get the tor proxy configuration string

a530be2

handling tor unavailable scenario

04bb6df

added in the tor indicator to the address bar

a1b326b

added in warning if tor is on and you\'re attempting to navigate to a…

a5123ea

…n external link

removing some debugging code

a618d13

wired in translations for the external link tor warning modal

e1dd826

WIP - redign to support editing active connection

554b81b

wired in server disconnect button

f31263c

handling deleting a live connection

dcf6a36

unbinding proxy set handlers before binding new ones in the server co…

f12c9ac

…nnect module

cleaning up unnecessary clos click targets from the debug log modal

9455761

fixed a bug where the navigable state of the page nav was not being s…

aa4aed9

…et properly

authenticated to the built-in server via an auth token

db6a79e

removing some debugging code

925fae6

merged in master

e0be2a6

some code cleanup

cd2108e

fixing double path seperator issue

289aaad

jjeffryes suggested changes Jul 14, 2017

View reviewed changes

rmisio added 2 commits July 17, 2017 10:18

some code review tweaks

dbd2c06

removing transtion from tool tips

7eb1ac4

jjeffryes approved these changes Jul 17, 2017

View reviewed changes

jjeffryes merged commit 8663ba4 into master Jul 17, 2017

jjeffryes deleted the tor branch July 17, 2017 17:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tor #560

Tor #560

rmisio commented Jul 11, 2017 •

edited

Loading

cpacia commented Jul 12, 2017

rmisio commented Jul 12, 2017

cpacia commented Jul 12, 2017

cpacia commented Jul 12, 2017

rmisio commented Jul 12, 2017 •

edited

Loading

morebrownies commented Jul 12, 2017

morebrownies commented Jul 13, 2017

rmisio commented Jul 13, 2017 •

edited

Loading

morebrownies commented Jul 13, 2017

morebrownies commented Jul 13, 2017

rmisio commented Jul 13, 2017

jjeffryes left a comment

jjeffryes Jul 14, 2017

jjeffryes Jul 14, 2017

rmisio Jul 14, 2017 •

edited

Loading

rmisio Jul 14, 2017

rmisio commented Jul 17, 2017 •

edited

Loading

Tor #560

Tor #560

Conversation

rmisio commented Jul 11, 2017 • edited Loading

To test:

cpacia commented Jul 12, 2017

rmisio commented Jul 12, 2017

cpacia commented Jul 12, 2017

cpacia commented Jul 12, 2017

rmisio commented Jul 12, 2017 • edited Loading

morebrownies commented Jul 12, 2017

morebrownies commented Jul 13, 2017

rmisio commented Jul 13, 2017 • edited Loading

morebrownies commented Jul 13, 2017

morebrownies commented Jul 13, 2017

rmisio commented Jul 13, 2017

jjeffryes left a comment

Choose a reason for hiding this comment

jjeffryes Jul 14, 2017

Choose a reason for hiding this comment

jjeffryes Jul 14, 2017

Choose a reason for hiding this comment

rmisio Jul 14, 2017 • edited Loading

Choose a reason for hiding this comment

rmisio Jul 14, 2017

Choose a reason for hiding this comment

rmisio commented Jul 17, 2017 • edited Loading

rmisio commented Jul 11, 2017 •

edited

Loading

rmisio commented Jul 12, 2017 •

edited

Loading

rmisio commented Jul 13, 2017 •

edited

Loading

rmisio Jul 14, 2017 •

edited

Loading

rmisio commented Jul 17, 2017 •

edited

Loading