Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Generalized fix for "name publish failed" issues #1593

Closed
placer14 opened this issue May 21, 2019 · 6 comments · Fixed by #1637
Closed

Generalized fix for "name publish failed" issues #1593

placer14 opened this issue May 21, 2019 · 6 comments · Fixed by #1637
Assignees
@placer14
Labels
bug feature Feature or enhancement to openbazaar-go

Comments

@placer14
Copy link
Member

Test general fix to delete cached private key from Namesys Datastore on-demand as a user-triggerable action. Will probably deliver this as a separate subcommand, but simple feasibility will be a modified build tailored specifically for a test user which always deletes the cached private key on startup.

This is a potential fix for #1564
@placer14 placer14 self-assigned this May 21, 2019
@placer14 placer14 added bug feature Feature or enhancement to openbazaar-go labels May 21, 2019
placer14 added a commit that referenced this issue May 21, 2019
@placer14
[#1593] Add Start subcommand option to force key purge from IPNS cache
76921e7
@placer14
Copy link
Member Author

placer14 commented May 21, 2019 •
edited
Loading

When using the binary built from this branch (https://github.com/OpenBazaar/openbazaar-go/tree/v0.13.3-hotfix, SHA 50a217a), the start subcommand now accepts a --forcekeypurge argument which will drop the cached private key and regenerate it. This argument should be tested on a backup copy of data folder using the -d flag. When using this key successfully, the following output will appear in the logs forcing key purge from namesys cache.... If this fix is successful, regular publishes to IPNS should proceed as they did before.

placer14 added a commit that referenced this issue May 23, 2019
@placer14
[#1593] Add Start subcommand option to force key purge from IPNS cache
50a217a
@placer14
Copy link
Member Author

placer14 commented May 23, 2019 •
edited
Loading

Private test appeared to be successful. Updated the instructions above with a new branch which is derived from the v0.13.3 release and not master for broader testing/use. Will assist manually applying fix while we attempt to better understand why the problem is occurring in the first place.

@placer14
Copy link
Member Author

placer14 commented Jun 3, 2019

After further tests with a v0.13.3-derived build, the problem subsides briefly and then returns. There is likely another detail which is contributing to this problem in our caching of our keys. The idea to segregate the cache used by the node from the cache used by the IPNS keystore has produced the following fix (#1613) which we'll merge into this branch and manually test as the next step.

@placer14
Copy link
Member Author

placer14 commented Jun 5, 2019

Some builds have been prepared for internal testing with users in the public slack. Want to do some additional testing with more users. Will also include #1613 in a separate test to see if there are improvements worth moving this to be included in the hotfix as well.

placer14 added a commit that referenced this issue Jun 13, 2019
@placer14
[#1593] Add Start subcommand option to force key purge from IPNS cache
a11ee1a
@placer14
Copy link
Member Author

After performing a few more tests, we found that a combination of removing the bad data as well as segregating the data used by different parts of the app so they wouldn't collide seems to do a better job of consistently resolving the bad key issues we've been experiencing. Planning to include a fix for this in the upcoming v0.13.4 release.

@placer14
Copy link
Member Author

Official steps to apply fix: https://openbazaar.zendesk.com/hc/en-us/articles/360029878631

@placer14 placer14 mentioned this issue Jul 10, 2019
Merged
@placer14 placer14 changed the title Test generalized fix for "name publish failed" issues Generalized fix for "name publish failed" issues Jul 29, 2019
anchaj added a commit to phoreproject/pm-go that referenced this issue Aug 1, 2019
@anchaj
Merge commit 'v0.13.4-rc1' into development
46abac7 
* commit 'a68e0e617eaa1a3ffa134bc08250b27341e847b4':
  Bump version to 0.13.4
  [OpenBazaar#1626] Fix secio handshake to properly fallback to alt ID generation
  [OpenBazaar#1634] Apply patch from go-libp2p-secio v0.0.3 release
  [OpenBazaar#1593] Add Start subcommand option to force key purge from IPNS cache
  Use separate namespace for IPNS persistent cache
  Best effort delete ipns record if unmarshaling fails
anchaj added a commit to phoreproject/pm-go that referenced this issue Aug 8, 2019
@anchaj
Merge branch 'development' into pre-release
c8fee82 
* development: (77 commits)
  Fix imports.
  Remove unused gx code.
  Delete unused code.
  Purge unused packages.
  Add missing gx packages.
  Handle error when calculating SHA peer id
  [OpenBazaar#1645] Prevent notifications produced on MODERATOR_ADD and REMOVE
  Bump version to 0.13.4
  [OpenBazaar#1626] Fix secio handshake to properly fallback to alt ID generation
  [OpenBazaar#1634] Apply patch from go-libp2p-secio v0.0.3 release
  [OpenBazaar#1593] Add Start subcommand option to force key purge from IPNS cache
  Use separate namespace for IPNS persistent cache
  Best effort delete ipns record if unmarshaling fails
  Don't cache records for our own peerID
  Add validator in mobile package
  Add record validator to APIRouter
  [OpenBazaar#1557] Make CachingRouter implement routing.PubKeyFetcher
  [OpenBazaar#1557] CachingRouter network lookup fixes
  Cleanup function naming, lint failures
  Update mobile/node to use extracted config methods
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@placer14 placer14

Labels
bug feature Feature or enhancement to openbazaar-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge fixes from v0.13.4 OpenBazaar/openbazaar-go
1 participant
@placer14