Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Add logging for mobile nodes #1539

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Add logging for mobile nodes #1539

merged 3 commits into from
Jun 4, 2019

Conversation

hoffmabc
Copy link
Member

@hoffmabc hoffmabc added the feature Feature or enhancement to openbazaar-go label Apr 11, 2019
@hoffmabc hoffmabc requested review from placer14 and cpacia April 11, 2019 18:07
@hoffmabc hoffmabc self-assigned this Apr 11, 2019
@coveralls
Copy link

coveralls commented Apr 11, 2019

Coverage Status

Coverage increased (+0.05%) to 35.622% when pulling a9de517 on mobile-logging into deab8d1 on master.

Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just need to test this works properly on both platforms. GTM otherwise.

mobile/node.go Show resolved Hide resolved
@placer14 placer14 requested a review from drwasho April 16, 2019 14:57
@placer14
Copy link
Member

placer14 commented Apr 16, 2019

I tried to test this but was unable to get my build to complete (On Android Studio, it failed while it was syncing gradle? Are there build instructions anywhere?). Can we get a confirmation on whether this works or not before we merge? /cc @hoffmabc @drwasho

Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this will only log ob-go to stdout and will put both ob-go and ipfs logs to file. We might consider not having logs to stdout for mobile. They're visible in logcat, but it's overhead that very few will take advantage of.

@placer14 placer14 merged commit 46d975e into master Jun 4, 2019
@placer14 placer14 deleted the mobile-logging branch June 4, 2019 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature or enhancement to openbazaar-go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants