Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Use go-emoji to convert to html chars #1543

Merged
merged 2 commits into from
May 22, 2019
Merged

Use go-emoji to convert to html chars #1543

merged 2 commits into from
May 22, 2019

Conversation

hoffmabc
Copy link
Member

Potential fix for #1542

@hoffmabc hoffmabc added the feature Feature or enhancement to openbazaar-go label Apr 15, 2019
@hoffmabc hoffmabc requested a review from placer14 April 15, 2019 14:06
@hoffmabc hoffmabc self-assigned this Apr 15, 2019
placer14
placer14 approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's undo the noisy import changes and squash all of this into a single commit. Then it'll be GTM.

core/core.go Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
placer14
placer14 approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most beautiful PR ever. 😭 👍

@coveralls
Copy link

coveralls commented Apr 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 35.652% when pulling 48c2e0c on brian.fix-emojis into 1000f97 on master.

@placer14
Copy link
Member

I removed the dependency on the assert library. One less thing to vendor. Let's see if travis passes and then we'll merge.

@cpacia
Copy link
Member

cpacia commented Apr 24, 2019

For this one maybe we should add a test to make sure non-emoji strings do not get mutated?

@cpacia cpacia merged commit 6ef2c67 into master May 22, 2019
@placer14 placer14 mentioned this pull request May 23, 2019
Closed
@placer14 placer14 deleted the brian.fix-emojis branch May 23, 2019 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@placer14 placer14 placer14 approved these changes

Assignees

@hoffmabc hoffmabc

Labels
feature Feature or enhancement to openbazaar-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoffmabc @coveralls @placer14 @cpacia