Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Add API router functionality #1544

Merged
merged 23 commits into from
Apr 17, 2019
Merged

Add API router functionality #1544

merged 23 commits into from
Apr 17, 2019

Conversation

cpacia
Copy link
Member

@cpacia cpacia commented Apr 15, 2019

Requirements

  • Create API routing implementation that queries a server for IPNS values (but not IPFS providers).

  • Create a wrapper around API router and the DHT that tires the DHT first where possible then the API.

  • Whenever querying for values, returned values should be pushed back to the API to make sure the API has them available.

  • Publishes should go out to all routers.

  • Remove the obsolete code which queried the gateway for IPNS values when the DHT failed.

  • Migrate the config file to include the new API router URI

  • Make sure API router can handle sending queries over Tor.

  • API router not used when in regtest mode.

@coveralls
Copy link

coveralls commented Apr 15, 2019

Coverage Status

Coverage increased (+0.05%) to 35.688% when pulling 3ad71cd on TS_api_router into 1000f97 on master.

@placer14 placer14 changed the title [WIP] Add API router functionality Add API router functionality Apr 16, 2019
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor points, but overall this looks good!

ipfs/caching_router.go Outdated Show resolved Hide resolved
ipfs/caching_router.go Outdated Show resolved Hide resolved
ipfs/api_router.go Show resolved Hide resolved
ipfs/api_router.go Outdated Show resolved Hide resolved
@placer14
Copy link
Member

Thanks, LGTM

@cpacia cpacia merged commit e43d939 into master Apr 17, 2019
@placer14 placer14 mentioned this pull request Apr 18, 2019
@placer14 placer14 added the feature Feature or enhancement to openbazaar-go label Apr 18, 2019
@cpacia cpacia deleted the TS_api_router branch July 15, 2019 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature or enhancement to openbazaar-go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants