Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Proper network lookup fix #1560

Merged
merged 4 commits into from
Apr 29, 2019
Merged

Proper network lookup fix #1560

merged 4 commits into from
Apr 29, 2019

Conversation

placer14
Copy link
Member

@placer14 placer14 commented Apr 26, 2019

Fixes #1557
Fixes #1556

- Properly consider the response from cachingRouter.IpfsRouting.GetValue
could be present with an error
- Remove API router from SearchValue until validation is included again
@placer14 placer14 added the bug label Apr 26, 2019
@placer14 placer14 requested review from tyler-smith and cpacia April 26, 2019 18:31
@placer14 placer14 self-assigned this Apr 26, 2019
@coveralls
Copy link

coveralls commented Apr 26, 2019

Coverage Status

Coverage decreased (-0.04%) to 35.51% when pulling b478fd7 on proper-network-lookup-fix into 35844a3 on master.

@cpacia cpacia merged commit 97d21ff into master Apr 29, 2019
@placer14 placer14 deleted the proper-network-lookup-fix branch April 29, 2019 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listings not resolving properly on mainnet API Router does not validate responses
3 participants