Migrate listing hashes in index to new format #1590

cpacia · 2019-05-20T15:12:25Z

Migration029 updates the hash of each listing in the listing index to use
the new hash format.

Fixes #1568

Migration029 updates the hash of each listing in the listing index to use the new hash format. Fixes #1568

coveralls · 2019-05-20T15:20:24Z

Coverage increased (+0.05%) to 35.63% when pulling b271fa6 on listingmigration into cacb790 on master.

placer14

I have a couple of suggestions and questions for this PR.

repo/migrations/Migration029.go

repo/migrations/Migration029_test.go

placer14

@cpacia Just the correction on the variables mentioned above, please.

repo/migrations/Migration029_test.go

Create migration029

2a4841f

Migration029 updates the hash of each listing in the listing index to use the new hash format. Fixes #1568

cpacia force-pushed the listingmigration branch from f45b7ed to 2a4841f Compare May 20, 2019 15:13

placer14 suggested changes May 23, 2019

View reviewed changes

repo/migrations/Migration029.go Show resolved Hide resolved

repo/migrations/Migration029.go Outdated Show resolved Hide resolved

repo/migrations/Migration029_test.go Outdated Show resolved Hide resolved

repo/migrations/Migration029_test.go Show resolved Hide resolved

placer14 suggested changes May 28, 2019

View reviewed changes

repo/migrations/Migration029_test.go Outdated Show resolved Hide resolved

Clean up nits in Migration029

b271fa6

cpacia force-pushed the listingmigration branch from 91620f0 to b271fa6 Compare May 29, 2019 15:04

cpacia merged commit b0bc590 into master Jun 6, 2019

cpacia deleted the listingmigration branch July 15, 2019 11:29

placer14 changed the title ~~Create migration029~~ Migrate listing hashes in index to new format Jul 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate listing hashes in index to new format #1590

Migrate listing hashes in index to new format #1590

cpacia commented May 20, 2019

coveralls commented May 20, 2019 •

edited

Loading

placer14 left a comment

placer14 left a comment

Migrate listing hashes in index to new format #1590

Migrate listing hashes in index to new format #1590

Conversation

cpacia commented May 20, 2019

coveralls commented May 20, 2019 • edited Loading

placer14 left a comment

Choose a reason for hiding this comment

placer14 left a comment

Choose a reason for hiding this comment

coveralls commented May 20, 2019 •

edited

Loading