This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Re-send missed ORDER messages on processing failure #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
force-pushed
the
mg-resend-order-msg-spike-2
branch
2 times, most recently
from
b13ac4f to
2d35721
Compare
amangale
reviewed
Jul 31, 2019
amangale
reviewed
Jul 31, 2019
amangale
reviewed
Jul 31, 2019
placer14
force-pushed
the
mg-resend-order-msg-spike-2
branch
3 times, most recently
from
1dac706 to
5a0a47e
Compare
placer14
changed the title
placer14
changed the title
drwasho
added
the
🔍 readyForReview
placer14
force-pushed
the
mg-resend-order-msg-spike-2
branch
from
5a0a47e to
0dedf90
Compare
placer14
force-pushed
the
mg-resend-order-msg-spike-2
branch
from
0dedf90 to
bf9740f
Compare
cpacia
reviewed
Aug 7, 2019
cpacia
reviewed
Aug 7, 2019
…-spike-2
Conflicts:
net/service/handlers.go
pb/protos/message.proto
pb/*.go
|
LGTM |
placer14
removed
the
🔍 readyForReview
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some code to explore how the resending of missed ORDER messages might work. This PR will serve as a means for discussion on approach. If everyone feels good about it and I don't see further bugs in my tests, I'll cherry-pick these into a cleaner history and prepare a formal PR to merge.
Proposed to fix #1069