Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable pre-commit autocommit #131

Merged
merged 4 commits into from
Mar 26, 2023
Merged

Conversation

kjappelbaum
Copy link
Collaborator

@kjappelbaum kjappelbaum commented Mar 25, 2023

I also broke one too-long line in prepare_chemrxiv.py. Otherwise, we always have a failing CI, which defeats its purpose.

@kjappelbaum kjappelbaum requested review from maw501 and MicPie March 25, 2023 17:46
@kjappelbaum kjappelbaum linked an issue Mar 25, 2023 that may be closed by this pull request
@maw501
Copy link
Contributor

maw501 commented Mar 26, 2023

Rather than breaking lines up could you just add # noqa after the line and it should get ignored (this works for most tools)?

@kjappelbaum
Copy link
Collaborator Author

Rather than breaking lines up could you just add # noqa after the line and it should get ignored (this works for most tools)?

sure we can also do that.

@kjappelbaum kjappelbaum merged commit a9af21a into main Mar 26, 2023
@kjappelbaum kjappelbaum deleted the kjappelbaum/issue130 branch March 26, 2023 15:34
MicPie pushed a commit to phalem/chemnlp that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update pre-commit
2 participants