-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add antibody developability from TDC #99
base: main
Are you sure you want to change the base?
Conversation
add Antibody Developability from: https://tdcommons.ai/single_pred_tasks/develop/ for both: TAP SAbDab, Chen et al. Need some one to ensure two list that I convert to two columns. Thanks
for more information, see https://pre-commit.ci
data/SAbDab_Chen/meta.yaml
Outdated
- https://rb.gy/idkdqp | ||
- https://rb.gy/b8cx8i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With URIs we mean links to ontologies, such as the ones you can find here https://bioportal.bioontology.org/ontologies/BAO?p=classes&conceptid=http://purl.obolibrary.org/obo/NCIT_C20604
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed those as they were not fitting our setup.
data/SAbDab_Chen/meta.yaml
Outdated
description: "Antibody data from Chen et al, where they process from the SAbDab. \n From an initial dataset of 3816 antibodies, they retained 2426\ | ||
\ antibodies\n that satisfy the following criteria: 1. \n have both sequence (FASTA) and Protein Data Bank (PDB) structure files,\n \ | ||
\ 2. contain both a heavy chain and a light chain, and 3. \n have crystal structures with resolution < 3 Å. \n The DI label is derived\ | ||
\ from BIOVIA's pipelines." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the linebreaks seems a bit awkward, do you have an idea where they come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that was the Ångström Å!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I converted to nm.
data/SAbDab_Chen/meta.yaml
Outdated
- id: antibody_pdb_ID | ||
type: Other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are those IDs chemically meaningful or just some identifier number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the pdb id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should we keep them or remove them?
data/SAbDab_Chen/meta.yaml
Outdated
- "@article{Chen2020,\n doi = {10.1101/2020.06.18.159798},\n url = {https://doi.org/10.1101/2020.06.18.159798},\n year =\ | ||
\ {2020},\n month = jun,\n publisher = {Cold Spring Harbor Laboratory},\n author = {Xingyao Chen and Thomas Dougherty and\ | ||
\ \n Chan Hong and Rachel Schibler and Yi Cong Zhao and \n Reza Sadeghi and Naim Matasci and Yi-Chieh Wu and Ian Kerman},\n \ | ||
\ title = {Predicting Antibody Developability from Sequence \n using Machine Learning}}" | ||
- "@article{Dunbar2013,\n doi = {10.1093/nar/gkt1043},\n url = {https://doi.org/10.1093/nar/gkt1043},\n year = {2013},\n\ | ||
\ month = nov,\n publisher = {Oxford University Press ({OUP})},\n volume = {42},\n number = {D1},\n pages\ | ||
\ = {D1140--D1146},\n author = {James Dunbar and Konrad Krawczyk and Jinwoo Leem \n and Terry Baker and Angelika Fuchs and Guy Georges\ | ||
\ and Jiye Shi and\n Charlotte M. Deane},\n title = {{SAbDab}: the structural antibody database},\n journal = {Nucleic\ | ||
\ Acids Research}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also surprised by the linebreaks here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this also due to the Å? Anyway, fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot - again 💯 Amazing contributions 👍🏽
I made some comments on one of the files. I think we anyhow wanted to discuss, let me know when you have time
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add benchmark field
tap cleanup is incoming, will finish up later |
I need to understand better if the identifier columns taken alone are enough - I do not think so |
Discuss: Better use Å instead of nm! |
add Antibody Developability from:
https://tdcommons.ai/single_pred_tasks/develop/
for both:
TAP
SAbDab, Chen et al.
Need some one to ensure two list that I convert to two columns. Thanks