-
Notifications
You must be signed in to change notification settings - Fork 15
Description
At present, the restraint forces that are created during the Sire-to-OpenMM conversion are set to use periodic boundary conditions. For bonded restraints, this doesn't make sense since a restraint could be satisfied in different ways depending on whether it is measured across the boundary or not, e.g. a molecule could extend, or contract, e.g. in a ring-breaking simulation.
I'm not sure whether we want to update all of the restraint classes in Sire::MM to add a use_pbc option in the constructor, or simply disable periodicity in the conversion layer. The former is more general, but requires a lot of updates and changes to the streaming operator versioning for all restraint classes. One complexity is the "distance" restraint, which is also used for "bond" restraints. I imagine the desired periodicity is different depending on whether you want to restraint a bond, or keep an atom close to some reference position.