-
Notifications
You must be signed in to change notification settings - Fork 15
Fix issue #371 #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #371 #372
Conversation
|
Oh, and just to add that I've checked that the legacy AmberParams tests still pass. |
chryswoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I think the only thing to keep an eye on is if the cost of finding all paths becomes very high for molecules with lots of rings?
|
Yes, good point. I'll get users to test. Hopefully we can run it over a range of inputs during the |
|
Actually, it will make no difference since |
This PR closes #371 by ensuring that the output of
Connectivity::findPathis reproducible and considering all 4 atom paths when adding missing dihedrals for when looping over 1-4 pairs. I have tested this via the SOMD1 compatibility layer in SOMD2, but can try to come up with a unit test here if desired.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]