-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add included services #228
base: main
Are you sure you want to change the base?
Conversation
Hey @Symbitic, thanks a lot for these contributions! In order to help me speed up the review, testing and merging of your features, could you split the changes of this MR into smaller MRs that I can individually try out? Top of my mind, the separation I would make is:
I hope this can help make the addition of features much faster and easier to test :D |
Sure. I'll extract included services and power state from this and leave it as just capabilities. |
I stand corrected: I leave this PR as included services and extracted capabilities and power state to separate PRs. |
9dfb30e
to
a655d39
Compare
@kdewald any updates? |
This adds several characteristic capabilities that were missing.
It also adds
included_services()
, but it returns it as an array of UUIDs instead of objects.