Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add included services #228

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Symbitic
Copy link
Contributor

This adds several characteristic capabilities that were missing.
It also adds included_services(), but it returns it as an array of UUIDs instead of objects.

@kdewald
Copy link
Member

kdewald commented Apr 7, 2023

Hey @Symbitic, thanks a lot for these contributions!

In order to help me speed up the review, testing and merging of your features, could you split the changes of this MR into smaller MRs that I can individually try out?

Top of my mind, the separation I would make is:

  • Characteristic capabilities
  • Included services
  • Power state

I hope this can help make the addition of features much faster and easier to test :D

@Symbitic
Copy link
Contributor Author

Symbitic commented Apr 7, 2023

Sure. I'll extract included services and power state from this and leave it as just capabilities.

@Symbitic
Copy link
Contributor Author

Symbitic commented Apr 8, 2023

I stand corrected: I leave this PR as included services and extracted capabilities and power state to separate PRs.

@Symbitic Symbitic changed the title Add included services and more capabilities Add included services Apr 8, 2023
@Symbitic
Copy link
Contributor Author

@kdewald any updates?

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants