Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snap to grid for angle-aligned lines #1094

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

letsfindaway
Copy link
Collaborator

This PR solves the issue reported here: #1013 (comment)

  • snap-to-grid did not work for lines that also fulfill the snap-to-angle criterion
  • check and compare the snap points for both criteria
  • if they result in the same line angle, then the snap-to-grid criterion is preferred

- snap-to-grid did not work for lines that also fulfill the
  snap-to-angle criterion
- check and compare the snap points for both criteria
- if they result in the same line angle, then the snap-to-grid criterion
  is preferred
- change angle of current line to snapped angle
- use end point as alternative position
- remove check for maximum distance for angle snap
- not necessary as snapping is now user controllable
@kaamui kaamui merged commit 1c41892 into OpenBoard-org:dev Sep 25, 2024
@letsfindaway letsfindaway deleted the fix-snap-grid-on-angle branch September 25, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants