Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use user platformdir also for user config #555

Merged
merged 3 commits into from
Jan 20, 2025
Merged

use user platformdir also for user config #555

merged 3 commits into from
Jan 20, 2025

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jan 20, 2025

change user and system config files to config_v1.yaml add system wide .env

@rettigl
use user platformdir also for user config
321f2fe 
change user and system config files to config_v1.yaml
add system wide .env
@rettigl rettigl requested a review from zain-sohail January 20, 2025 20:10
@coveralls
Copy link
Collaborator

coveralls commented Jan 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12876629025

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 92.174%
Totals Coverage Status
Change from base Build 12876237185: 0.007%
Covered Lines: 7703
Relevant Lines: 8357
💛 - Coveralls

zain-sohail
zain-sohail approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Prob an additional test for system config path but it's not necessary

@rettigl
Copy link
Member Author

rettigl commented Jan 20, 2025

additional test for system config path but it's not necessary

Added

@rettigl rettigl merged commit 8ff0040 into v1_feature_branch Jan 20, 2025
4 checks passed
@rettigl rettigl deleted the config_renaming branch January 20, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rettigl @coveralls @zain-sohail