Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Financial Data OpenCTI Module support to Client Python #667

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ParamConstructor
Copy link
Contributor

Proposed changes

This is the PYCTI changes required to support the OpenCTI PR - OpenCTI-Platform/opencti#5287

  • Add new observables: Financial Accounts, Financial Assets, and Financial Transactions
  • Add new vocabularies: financial_account_status, financial_account_type, asset_type, currency_code
  • Removed BankAccount and CryptoWallet observables (migrated to Financial Account in OpenCTI)
  • Add relation support for new observables

Related issues

  • This needs to be deployed in tandem with the OpenCTI PR
  • We have tested locally using unit tests / pytest locally - but the automated pipeline has not been used due to it checking out "master" on OpenCTI branch versus the equivalent "financial_data" branch

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

N/A

@ParamConstructor ParamConstructor mentioned this pull request May 30, 2024
5 tasks
@aHenryJard aHenryJard added the multi-repository When a PR requires several repository changes label May 30, 2024
@ParamConstructor ParamConstructor force-pushed the opencti/financial_data branch from 017cc03 to 1ca7953 Compare June 13, 2024 14:26
@Bonsai8863 Bonsai8863 force-pushed the opencti/financial_data branch from 1ca7953 to a91952a Compare June 19, 2024 12:16
@ParamConstructor ParamConstructor force-pushed the opencti/financial_data branch 5 times, most recently from e7ef484 to 7a9dafe Compare June 28, 2024 19:45
@Bonsai8863 Bonsai8863 force-pushed the opencti/financial_data branch 5 times, most recently from 2b10202 to 18e0066 Compare July 10, 2024 07:48
@Bonsai8863 Bonsai8863 force-pushed the opencti/financial_data branch from 18e0066 to eaa7812 Compare July 18, 2024 14:41
@SouadHadjiat SouadHadjiat added the community use to identify PR from community label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community multi-repository When a PR requires several repository changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants