Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shadowserver] Fix shadowserver and add additional pytests #3104 #3141

Merged
merged 4 commits into from
Jan 8, 2025
Merged

[Shadowserver] Fix shadowserver and add additional pytests #3104 #3141

merged 4 commits into from
Jan 8, 2025
+832 −784

Conversation

cmandich
Copy link
Contributor

@cmandich cmandich commented Dec 13, 2024 •
edited
Loading

Proposed changes

  • Fixed vulnerability id generation
  • Added additional pytests to validate stix transformation for report types
  • Minor tweaks

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@cmandich cmandich changed the title Fix shadowserver and add additional pytests #3104 [Shadowserver] Fix shadowserver and add additional pytests #3104 Dec 13, 2024
@romain-filigran romain-filigran added the community use to identify PR from community label Dec 27, 2024
Megafredo
Megafredo approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@Megafredo Megafredo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me, thanks for your contribution ;)

PS : @cmandich, unfortunately, there's a bit of a problem: all your commits need to be signed.

@romain-filigran romain-filigran added this to the PRs backlog milestone Jan 7, 2025
@romain-filigran
Copy link
Member

@cmandich : Hi Chris. Is it possible for you to sign your code so that we can merge your contribution? Thanks in advance

@cmandich
Copy link
Contributor Author

cmandich commented Jan 8, 2025

@romain-filigran, just signed! Thank you!

@Megafredo Megafredo merged commit dc97f68 into OpenCTI-Platform:master Jan 8, 2025
4 checks passed
@Megafredo Megafredo linked an issue Jan 8, 2025 that may be closed by this pull request
[Shadowserver] ERROR type object 'Vulnerability' has no attribute 'generate_id' #3104
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

Assignees
No one assigned
Labels
community use to identify PR from community improvement
Projects
None yet
Milestone
PRs backlog
Development

Successfully merging this pull request may close these issues.

[Shadowserver] ERROR type object 'Vulnerability' has no attribute 'generate_id'
3 participants
@cmandich @romain-filigran @Megafredo