Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] use context to prefill the dynamic entity mapping column #9087

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Nov 19, 2024

Proposed changes

  • add CsvMapperContext to pass the dynamicMappingColumn to the others representation
  • add onToggleDynamicMapping to set the dynamicMappingColumn
  • add useState to modify the value of the dynamicMappingColumn

Related issues

  • 7400

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.00%. Comparing base (00813e7) to head (bec31fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9087      +/-   ##
==========================================
- Coverage   65.01%   65.00%   -0.01%     
==========================================
  Files         624      624              
  Lines       59520    59520              
  Branches     6597     6593       -4     
==========================================
- Hits        38695    38690       -5     
- Misses      20825    20830       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe force-pushed the issue/dynamic-entity-mapping-context branch from 62a9411 to 2f4cf7d Compare November 19, 2024 16:42
@CelineSebe CelineSebe changed the title [frontend] use context to prefill the dynamic entity mapping [frontend] use context to prefill the dynamic entity mapping column Nov 19, 2024
@CelineSebe CelineSebe marked this pull request as ready for review November 19, 2024 16:54
@CelineSebe CelineSebe self-assigned this Nov 19, 2024
@CelineSebe CelineSebe requested a review from lndrtrbn November 25, 2024 13:32
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Warnings and errors in console while manipulating the fields for dynamic mapping to fix,
  • You cannot empty the fields Column index and Operator,
  • What column should be kept in the context ? The first one set or the last one ? Currently it is the last one

@CelineSebe CelineSebe force-pushed the issue/dynamic-entity-mapping-context branch from 2f4cf7d to e39a3fa Compare November 26, 2024 13:41
@CelineSebe CelineSebe marked this pull request as draft November 26, 2024 14:27
@CelineSebe CelineSebe marked this pull request as ready for review November 26, 2024 17:07
@CelineSebe CelineSebe merged commit d79eff0 into master Nov 27, 2024
6 checks passed
@CelineSebe CelineSebe deleted the issue/dynamic-entity-mapping-context branch November 27, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants