feat: new error handling #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 78fb8cc into da9f954 - view on LGTM.com new alerts:
|
Nebulis
reviewed
Aug 28, 2020
test/verify.v3.test.ts
Outdated
| @@ -98,7 +98,7 @@ describe("verify", () => { | |||
| expect(isValid(results)).toStrictEqual(false); | |||
| expect(isValid(results, ["DOCUMENT_INTEGRITY", "DOCUMENT_STATUS"])).toStrictEqual(true); | |||
| }); | |||
| it("should fail for when identity is invalid and be valid for remaining checks when document with certificate store is valid on ropsten", async () => { | |||
| it("should fail for when identity is invalid and be valid for remaining checks when document with certificate store is valid on ropsten", async () => { | |||
There was a problem hiding this comment.
remove for in should fail for ?
There was a problem hiding this comment.
ah i missed this, it's fixed in a3b65bb. yep we should remove the "for"
|
This pull request introduces 1 alert when merging 3c5a1fb into da9f954 - view on LGTM.com new alerts:
|
Nebulis
approved these changes
Aug 31, 2020
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
github:Open-Attestation/oa-verify#feat/new-errorsoa-verifyrefer to Open-Attestation/oa-verify#110 for the full changelog