Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate bond distances in template tool #1099

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

aerkiaga
Copy link
Collaborator

Signed-off-by: Aritz Erkiaga aerkiaga3@gmail.com

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Aritz Erkiaga <aerkiaga3@gmail.com>
@aerkiaga
Copy link
Collaborator Author

It's still missing polydentate ligands, but it's a start...

@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

The bidentate distance bothered me, but it turns out to be fairly easy:

  • calculate the M-* distance => b
  • calculate the M-* distance => c
  • calculate the * * distance => a
    Now the goal distance is the height of that triangle, e.g. the last line of Eq. 3 here: https://math.stackexchange.com/a/680275/807336

@ghutchis
Copy link
Member

Is this still WIP? Seems like it's pretty much ready.

@aerkiaga aerkiaga changed the title WIP: Estimate bond distances in template tool Estimate bond distances in template tool Aug 15, 2022
@ghutchis ghutchis merged commit 020d117 into OpenChemistry:master Aug 16, 2022
@aerkiaga aerkiaga deleted the template-bond-distances branch August 16, 2022 00:57
@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants