Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If userOptions specifies an order, use that to sort the form #1503

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

ghutchis
Copy link
Member

@ghutchis ghutchis commented Dec 5, 2023

Fix #1498

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Fix OpenChemistry#1498

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@avo-bot
Copy link

avo-bot commented Dec 5, 2023

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/december-2023-live-updates/5051/1

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@matterhorn103
Copy link
Contributor

matterhorn103 commented Dec 5, 2023

This has a slightly odd bug whereby if the first item in a dialog (set by "order") is a field of type "string", the value set by "default" is wiped and the text box is displayed as empty. Drop down "stringList"s also get reset to the value with index 0 if they are the top object. This only happens to the first object.

Edit: and if the type is "text" then the contents are simply not displayed i.e. presumably they are replaced with an empty string

@ghutchis ghutchis merged commit 34b34ea into OpenChemistry:master Dec 5, 2023
18 checks passed
@ghutchis ghutchis deleted the sort-user-option-order branch December 5, 2023 14:43
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@avo-bot
Copy link

avo-bot commented Dec 7, 2023

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/full-and-privileged-xtb-integration/4953/55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow plugins/extensions to request specific positions in menus, choose order of commands, layout of dialogs
3 participants