Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add centerOfGeometry, centerOfMass and radius methods on Molecule #499

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

dvermd
Copy link
Contributor

@dvermd dvermd commented Sep 30, 2020

Signed-off-by: dvermd 315743+dvermd@users.noreply.github.com

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Closes: #223

Signed-off-by: dvermd <315743+dvermd@users.noreply.github.com>
@ghutchis
Copy link
Member

ghutchis commented Oct 2, 2020

This looks good so far. I'd be willing to merge this and merge the best-fit plane as a separate PR.

@dvermd
Copy link
Contributor Author

dvermd commented Oct 3, 2020

I'm happy with this PR been merged and creating another one for the best-fit plane

@ghutchis ghutchis changed the title WIP: Add centerOfGeometry, centerOfMass and radius methods on Molecule Add centerOfGeometry, centerOfMass and radius methods on Molecule Oct 4, 2020
@ghutchis ghutchis merged commit 78bd7ab into OpenChemistry:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate center of geometry
2 participants