Simplify wheel building #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running programs like cibuildwheel, this allows us to more easily append extra cmake arguments to the list via an environment variable. The cmake arguments are semicolon delimited. Example: EXTRA_CMAKE_ARGS=-DEIGEN3_INCLUDE_DIR=/c/eigen;-DBUILD_TYPE=Release Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This checks if pybind11 was installed via pip. If it was, then it will automatically include the pybind11 directory in the cmake arguments. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
The previous wheel-building infrastructure used appveyor, travis-ci, and circleci. Remove these as we are doing all of the wheel building on github actions now. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
I'll take a look at the other build failures - I've been busy with deadlines, but want to make sure we get regular builds / releases again. |
The test only imports avogadro, creates a molecule, and loads xyz data from a string, and verifies that the data was loaded properly. But this indicates that the wheels are at least functional. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
I think if you push again, it should fix the build_cmake failures - it was a problem with the openchemistry cmake files. |
|
@ghutchis Sounds good, I am simplifying one or two things. But it should be ready soon. |
This allows us to specify dependencies to install before setup.py is ran. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
I don't know why auditwheel can't see the libraries since they are already inside the wheel. If we can figure out how to get it to see the libraries, we can skip the whole script. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
I think this is ready to go! |
|
I'll check on the Windows build later - I don't think that's a serious problem. Do you know if we still need the Travis build or can we disable that after merging this? (I know it was to build wheels..) |
|
Looks good - the Windows break is on my side - should be fixed soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves wheel building over to use cibuildwheel and github actions. This simplifies the wheel building logic with a lot of shared script and code paths between platforms.
On new tag pushes, the built wheels will automatically be pushed to PyPI.
The following wheels were tested: