Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels #715

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Labels #715

merged 4 commits into from
Aug 11, 2021

Conversation

serk12
Copy link
Collaborator

@serk12 serk12 commented Aug 8, 2021

Labels display type and Label editor.
Thanks to @foowhiz for the initial start.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Marc Prat Masó <marc.prat.maso@estudiantat.upc.edu>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2021

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis added the enhancement feature changes / API changes label Aug 8, 2021
@ghutchis ghutchis mentioned this pull request Aug 9, 2021
@ghutchis ghutchis linked an issue Aug 9, 2021 that may be closed by this pull request
@ghutchis
Copy link
Member

I mentioned on Slack, but for now I'd rather split the two parts. The label engine is a good start, but I'm a bit less certain about the current UI for the label editor.

  • If the default labels show, would someone click and expect to edit the defaults?
  • Currently, clicking and editing doesn't always show the label
  • Will people expect to click bonds to label with bond length?
  • (Would people expect some sort of automatic text .. like click on bond to label the length by default?)

All of that could be added to your current code, but I want to talk to more users (and my students) to see what they might expect.

OTOH, the label engine works as-is.

@serk12
Copy link
Collaborator Author

serk12 commented Aug 11, 2021

Okey, then I delete the LabelEditor and once the behavior is defined we can recover the code from here.

Signed-off-by: Marc Prat Masó <marc.prat.maso@estudiantat.upc.edu>
@github-actions
Copy link
Contributor

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis merged commit 9601d30 into OpenChemistry:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature changes / API changes rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering: Labels
2 participants