test ">=0" within machine precision (>-EPS) #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test UnitCellTest.wrapAtomsToUnitCell fails on i386 (i686): [ RUN ] UnitCellTest.wrapAtomsToUnitCell /tmp/autopkgtest-lxc.w4hysxt4/downtmp/build.1Hw/src/tests/core/unitcelltest.cpp:265: Failure Expected: (it->y()) >= (static_cast<Real>(0.0)), actual: -1.44334e-18 vs 0 [ FAILED ] UnitCellTest.wrapAtomsToUnitCell (0 ms) Evidently the precision is too tight for 32-bit i386, such that it->y() is "mostly zero" but crosses just below 0, making the test fail. Replacing the test ">=0" with ">-EPS" enables the test to pass on i386. Fixes Issue OpenChemistry#812.
ghutchis
approved these changes
Dec 11, 2021
|
Congrats on merging your first pull request! 🎉 Thanks for making Avogadro better for everyone! |
|
Thanks - sorry for the delay - didn't get the notification on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test UnitCellTest.wrapAtomsToUnitCell fails on i386 (i686):
[ RUN ] UnitCellTest.wrapAtomsToUnitCell
/tmp/autopkgtest-lxc.w4hysxt4/downtmp/build.1Hw/src/tests/core/unitcelltest.cpp:265: Failure
Expected: (it->y()) >= (static_cast(0.0)), actual: -1.44334e-18 vs 0
[ FAILED ] UnitCellTest.wrapAtomsToUnitCell (0 ms)
Evidently the precision is too tight for 32-bit i386, such that it->y() is "mostly zero" but crosses just below 0, making the test fail.
Replacing the test ">=0" with ">-EPS" enables the test to pass on i386.
Fixes Issue #812.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.