-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin to focus or unfocus selection #868
Conversation
Signed-off-by: Aritz Erkiaga <aerkiaga3@gmail.com>
Here are the build results |
The idea is great. A few nitpick points.
Load
|
Signed-off-by: Aritz Erkiaga <aerkiaga3@gmail.com>
Everything done. The disappearing issue was due to a missed initialization, which should be fixed now. The current behavior is looking at the focused point from the current camera position, then scaling the view to put it at a fixed distance from the target. |
Signed-off-by: Aritz Erkiaga <aerkiaga3@gmail.com>
Here are the build results |
Much better. One more minor thing. I think the zoom level should be estimated based on the radius / size of the selection. Try this as an example. Download Focus. With this revision, you're zoomed in and can't even see the selection. It's a minor thing, but I think if we get this right, it will be a very popular feature. |
Signed-off-by: Aritz Erkiaga <aerkiaga3@gmail.com>
Here are the build results |
This pull request has been mentioned on Avogadro Discussion. There might be relevant details there: https://discuss.avogadro.cc/t/april-2022-development-progress/3786/1 |
Signed-off-by: Aritz Erkiaga aerkiaga3@gmail.com
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.